brusselopole / Worldopole

Worldopole is a third party extension for RocketMap showing some nice statistics.
MIT License
85 stars 79 forks source link

Improve Nests page #363

Closed 123FLO321 closed 5 years ago

123FLO321 commented 6 years ago

This PR requires/includes #353 (Will rebase once merged) I recommend settting nest_exclude_pokemon to an empty array ( '[ ]' ) Update your .htaccess (cp htaccess .htaccess)!

Changes in this PR: https://github.com/123FLO321/Worldopole/compare/db-types...123FLO321:nests

Description

Motivation and Context

Because veryone want's it.

How Has This Been Tested?

Testet and working fine locally.

I need do wait for migration tonight to test the clearing and early update.

Screenshots (if appropriate):

sc1

Types of changes

fosJoddie commented 6 years ago

I'd have to retest with very latest changes, but there's no explosions running this PR.

There are a few issues with how nests are done for the parks though:

This means that the "nest" for these parks will be whatever the weather decides the most common pokemon to be. Some days this is Oddish, other Swablu or Spheal, etc. Even if the nesting pokemon is a Ponyta it won't show up unless you go to frequent spawn mode.

Of course, I can just start using the next exclude again, which will then of course exclude any nests that happen to be those ones. So it's not really a big problem in any case.

But if the nest logic somehow could take rarity into account as well... that would be awesome. Since in some of my nests (like the Ponyta one) there's 6 of them every day. They just get silenced by the 24 oddishes. Maybe the algorithm need to take into account number of spawns pr species divided by spawnpoints (Oddish would then come out as 4 pr hour pr spawnpoint etc).

Anyhow.. just some ramblings on a solid piece of PR. I haven't been able to find any bugs so far at least, in my limited testing

edit: my setup: Rocketmap with weather PR, 4 instances. 4 worldopole setups with nginx in front.

123FLO321 commented 6 years ago

@fosJoddie One spawn point "Nests" are hard to catch. Maybe it would be possible to count weather-boosted Pokemon less that non weather-boosted ones.

Obihoernchen commented 5 years ago

Now in #371