brutella / hklifx

LIFX HomeKit bridge
Other
105 stars 17 forks source link

import `github.com/pdf/golifx/common` causing errors #15

Closed ehanderson closed 8 years ago

ehanderson commented 8 years ago

Steps:

# hklifx
./hklifxd.go:14: inconsistent definition for type common.SubscriptionTarget during import
    interface { CloseSubscription(*common.Subscription) error; NewSubscription() (*common.Subscription, error) } (in "github.com/pdf/golifx")
    interface { CloseSubscription(*<T>) error; NewSubscription() (*common.Subscription, error) } (in "github.com/pdf/golifx/common")```

I have also filed and issues on golifx: https://github.com/pdf/golifx/issues/5
brutella commented 8 years ago

It works for me with go v1.6

ehanderson commented 8 years ago

A few weeks ago it was working on 1.5.2 - so not sure what has changed?

brutella commented 8 years ago

Is this still an issue?

brutella commented 8 years ago

The source of golifx is now included in vendor/github.com/pdf/golifx. There is not need to locally fetch the library anymore.