bryanlabs / cosmos-tax-cli

An opensource cosmos tax tool!
https://defiantlabs.net
Apache License 2.0
25 stars 7 forks source link

Error in parsing multisig key to assign payer for fees #544

Closed pharr117 closed 7 months ago

pharr117 commented 7 months ago

During parsing of block 14653896 and transaction 6618BA7C75C97DE4D6D25B6651764A87DC607E6D292C779CBFE90687D216B52A a fatal error occured indicating an empty public key when trying to assign an address for the fee payer.

The issue occurred because the application is not handling multisig keys properly during fee processing. In ProcessFees, we were using string casts and comparisons to determine key type, which broke on this transaction as it does not return the same string anymore:

https://github.com/DefiantLabs/cosmos-tax-cli/blob/90793a306c0761a1808845638d2a8cb707f3aee2/core/tx.go#L577-L592

We need to turn this into interface casts to key types to get better parsing support for multisig keys while keeping the same behavior.