search

bryceosterhaus / atom-jest-snippets

:atom: :black_joker: Atom editor snippets for Jest
https://atom.io/packages/atom-jest-snippets
11 stars 9 forks source link

"Quote type" ignored #8

Open the0neWhoKnocks opened 5 years ago

the0neWhoKnocks commented 5 years ago

Doesn't seem that https://github.com/bryceosterhaus/atom-jest-snippets/pull/6 works. The default is set to ', I've restarted after I installed, and am still seeing " being used. Looking at the code in https://github.com/bryceosterhaus/atom-jest-snippets/pull/6/commits/e28a65b5fc81bced7cae387bdd1ae6b8829c1153 seems to imply that the quote type is never used, and it just always uses the hard-coded double quote.

bryceosterhaus commented 5 years ago

You're right, looks like we aren't generating the snippets correctly. We need to replace the hard coded quotes with quoteType

Would you mind sending a PR for this fix?