bsansouci / bsb-native

Build system for OCaml/Reason
Other
245 stars 10 forks source link

create default native init package #24

Closed ox closed 6 years ago

ox commented 6 years ago

This diff changes the basic theme init project from the default reason one to the code in https://github.com/bsansouci/bsb-native-example. It also mentions how to initialize a project in the README.

closes #20

ox commented 6 years ago

I'm having trouble makeing the BS compiler (following the CONTRIBUTING.md guide) with the following error:

File "src/ast_402.ml", line 87, characters 2-152:
Error: This variant or record definition does not match that of type
         Parsetree.payload
       Fields number 2 have different names, PSig and PTyp.
make[1]: *** [refmt3.exe] Error 2

I'm sure the diff makes the right folder template but I would like to test it more thoroughly.

bsansouci commented 6 years ago

Mmh two ideas come to mind:

Schmavery commented 6 years ago

Any reason not to add a js backend to the entries list?

bsansouci commented 6 years ago

Hey since we just did a release could you update this to use bsansouci/bsb-native#2.1.1

ox commented 6 years ago

@Schmavery This PR only covers #20: to create a native example project.

bsansouci commented 6 years ago

Ok if you can resolve the merge conflict, I'll merge.

bsansouci commented 6 years ago

Ok resolved the conflict on my side and merged. Thanks a lot :)

ox commented 6 years ago

@bsansouci sorry, was afk for a few days. Thanks!

bsansouci commented 6 years ago

No worries really. Github makes resolving merge conflict very easy :)