search

bsansouci / bsb-native

Build system for OCaml/Reason
Other
245 stars 10 forks source link

[WIP] Improved esy support #43

Open rauanmayemir opened 6 years ago

rauanmayemir commented 6 years ago

This PR streamlines the structure towards less hardcoded and more 'esy-way'. ninja-build and ocaml are dependencies, not vendor dumps.

bsansouci commented 6 years ago

Hey thanks for opening this. I really appreciate the help. That said I'd like to merge the esy branch inside master, so it's easier to maintain and I can actually dogwood it. For that, I need to keep the same vendored ocaml (and might as well keep ninja). I need it for JS compilation.

I'll merge the esy.json though, if that works :)

rauanmayemir commented 6 years ago

As long as it brings esy and bsb closer, no worries.

chenglou commented 6 years ago

yes please!

bsansouci commented 6 years ago

Heyyy how's this going? I'd love to get the esy.json merged since it's probably more correct than mine. Did you need to change anything inside bsb that makes the integration better?

rauanmayemir commented 6 years ago

Hey! Sorry, I didn't realise you meant merge esy.json from this PR. Let me clean up unused commits and check that it actually works.

I need to keep the same vendored ocaml

Do you mean the old 4.02?

bsansouci commented 6 years ago

No worries! Awesome, thank you so much.

Yeah, for now keeping 4.02.3. I'll address that problem later.