search

bsansouci / bsb-native

Build system for OCaml/Reason
Other
245 stars 10 forks source link

Generated binary name inconsistent between macos & windows (macos doesn't have .exe suffix) #68

Open jaredly opened 6 years ago

jaredly commented 6 years ago

It would make scripts a lot simpler if all platforms generated the same binary name.

jaredly commented 6 years ago

Is the fix as simple as changing https://github.com/bsansouci/bsb-native/blob/95055bec3e0acb728902babc4709c26fa9f0831d/jscomp/bsb/bsb_ninja_native.ml#L474 to just be .exe all the time?

bsansouci commented 6 years ago

Yeah should be sufficient

Schmavery commented 6 years ago

will break lots of little existing scripts so lets do it as part of a bigger upgrade if possible