country code in btcpay invoice, woocommerce admin compatibility

btcpayserver / woocommerce-plugin

Plugin for connecting Woocommerce with BTCPayServer

https://btcpayserver.org/

Other

51 stars 41 forks source link

country code in btcpay invoice, woocommerce admin compatibility #39

Closed pieterpoorthuis closed 4 years ago

pieterpoorthuis commented 4 years ago

Added option to include country code in Btcpay invoice
Modified invoice check to support woocommerce admin plugin

NicolasDorier commented 4 years ago

Seems to be good idea. I am a bit worried about the changes breaking in old version of Woocommerce.

What is breaking with woocommerce admin plugin exactly?

pieterpoorthuis commented 4 years ago

Seems to be good idea. I am a bit worried about the changes breaking in old version of Woocommerce.

What is breaking with woocommerce admin plugin exactly?

The former IPN processor had the following check: if (false === $order || ('WC_Order' !== get_class($order) && 'WC_Admin_Order' !== get_class($order))) { This check was too strict and always failed in our woocommerce install (with the woocommerce admin plugin active).

NicolasDorier commented 4 years ago

Ok let me know when you updated PR, will then merge and put new release.

pieterpoorthuis commented 4 years ago

Ok let me know when you updated PR, will then merge and put new release.

PR has been updated

NicolasDorier commented 4 years ago

cool thanks, testing it

NicolasDorier commented 4 years ago

I pushed 3.0.10 I messed up with bump version on a previous version.