search

btd1337 / urutau-icons

The most complete icon pack for 3rd applications with elementary OS design
GNU General Public License v3.0
116 stars 5 forks source link

icon request: makeMKV #5

Closed asmundur82 closed 7 years ago

asmundur82 commented 7 years ago

Hi is it possible to revert makemkv icon to a CD icon

btd1337 commented 7 years ago

Can you make a pull request?

asmundur82 commented 7 years ago

oh sorry i am new at this, i will make a pull request thank you

asmundur82 commented 7 years ago

cant figure out the pull request section, i was wondering if it is possible to use a icon for makemkv that is already in the icon-theme perhaps dvd95.svg or dvdrip.svg, thanks in advance

btd1337 commented 7 years ago

Support included in https://github.com/btd1337/elementary-full-icon-theme/commit/71174fe814b85331ed8d56c4f2f861785f0993fb

asmundur82 commented 7 years ago

Hi icon is not showing

asmundur82 commented 7 years ago

usr/share/applications/makemkv.desktop

asmundur82 commented 7 years ago

[Desktop Entry] Version=1.0 Name=MakeMKV Comment=DVD and Blu-ray to MKV converter and network streamer Exec=makemkv Icon=makemkv Terminal=false Type=Application Categories=AudioVideo;Qt;

btd1337 commented 7 years ago

The icon has been set. Be sure to update your icon pack.

Enter in icon pack folder (elementary-full-icon-theme) and update:

git pull

If you made any previous changes it's necessary make merge of the changes.

git merge git pull

captura de tela de 2017-06-25 13-05-59 captura de tela de 2017-06-25 13-06-19

asmundur82 commented 7 years ago

Hi, i have updated but there is no icon showing for makemkv and gcdemu

btd1337 commented 7 years ago

Thanks for your report. I fixed this in https://github.com/btd1337/elementary-full-icon-theme/commit/7b390683c83f8451469c035cbe1ac9351c610fd6 . Try again.

asmundur82 commented 7 years ago

thanks that worked