General improvements - Githubissues

btimofeev / UniPatcher

A game console ROM patcher for Android

GNU General Public License v3.0

155 stars 18 forks source link

General improvements #49

Closed TacoTheDank closed 3 years ago

TacoTheDank commented 3 years ago

1st commit

Update gradle wrapper to 6.8 using git bash

2nd commit

Reorganize and clean up the build gradles

3rd commit

Update NDK 21.3 -> 22.0 (changelog)
Update Dagger 2.28 -> 2.31.2 (changelog)
Update JUnit 4.13 -> 4.13.1 (changelog)
Update minimum CMake 3.4.1 -> 3.10.2
Update Undercouch plugin 4.0.0 -> 4.1.1 (changelog)

4th commit

Use some KTX extensions

5th commit

Clean up some Kotlin stuff

6th commit

Migrate the help page to ViewPager2 (see here)

7th commit

Regenerate (to latest material design) and rename drawables

btimofeev commented 3 years ago

Thank you!

TacoTheDank commented 3 years ago

@btimofeev Thanks for merging!

A small side note relating to your inversion commit here, I chose to do the double negative because while isInvisible returns either INVISIBLE or VISIBLE, isVisible returns either VISIBLE or GONE. Just wanted to make sure your change is actually intentional, since the view being gone means space for it is no longer reserved (while the original code had it simply being invisible) :)

(example here)

btimofeev commented 3 years ago

@TacoTheDank Yes, I got it. Both GONE and INVISIBLE are suitable for current layouts. The code is easier to read without inversion, so I fixed it.

TacoTheDank commented 3 years ago

@btimofeev Alright, thanks for responding :)