search

bttv-android / bttv

A mod of the Twitch Android Mobile App adding BetterTTV, FrankerFaceZ and 7TV emotes
MIT License
644 stars 21 forks source link

webp anim 7TV Emotes aren't animated #183

Closed StephanBruh closed 3 years ago

StephanBruh commented 3 years ago

Bug Report

Current Behavior Emotes on 7TV that should be animated are just static

Expected behavior/code 7TV Emotes are animated

Environment

welcome[bot] commented 3 years ago

Thank you for opening this issue ♥️ A maintainer should be by to give feedback soon. peepoArrive

FoseFx commented 3 years ago

Can't confirm. Are there certain emotes that don't work for you?

StephanBruh commented 3 years ago

Can't confirm. Are there certain emotes that don't work for you?

Oh yeah, looks like its only happening to certian wide animated emotes, some examples; https://7tv.app/emotes/60ae6b4486fc40d488d0b324 https://7tv.app/emotes/60b1868058275001781a8bd5 https://7tv.app/emotes/60b2cd2aab2a2a9c958b2695 https://7tv.app/emotes/60ae47919986a00349442244

But some do work for me like; https://7tv.app/emotes/6043a11f1d4963000d9dae4c https://7tv.app/emotes/6063d9f8f4dc10001426b946

chatterino: ezgif com-gif-maker (3)

app: ezgif com-gif-maker (4)

FoseFx commented 3 years ago

The reason is probably, that e.g. AlienGathering has the mime type image/webp not image/gif and bttv-android/Glide can not determine whether it should be animated.

FoseFx commented 3 years ago

This is a known issue in Glide, litte I can do about it https://github.com/bumptech/glide/issues/571 :/

StephanBruh commented 3 years ago

Damn thats a old issue, maybe your able to count the frames and change the mime?

FoseFx commented 3 years ago

I'll have a look at https://github.com/zjupure/GlideWebpDecoder and see if I can add it somehow

StephanBruh commented 3 years ago

Reopening issue because emotes with webp are still not animated.

emote example; https://7tv.app/emotes/60b529e7c871a89f1541972e https://7tv.app/emotes/60845b712a652395a02c56ef

FoseFx commented 3 years ago

I'm working on the v11.4.0 rebase right now and there it seems to work. Idk what fixed it but I'll take it. So this will be fixed in v0.11.0-beta.

Please note that webp animations are static in the EmotePicker right now (see #199)

StephanBruh commented 3 years ago

Alright thanks! Yeah I know they are static in the emote picker. Will wait for the beta then :)