search

bubelov / news

Feed Reader and Podcast Player for Android
https://f-droid.org/packages/co.appreactor.news/
GNU General Public License v3.0
411 stars 26 forks source link

Remove settings from bottom navigation #14

Closed bubelov closed 3 years ago

bubelov commented 3 years ago

I've been reading Material spec and I found the following recommendation:

Bottom navigation shouldn’t be used for:

  • Single tasks, such as viewing a single email
  • User preferences or settings

https://material.io/components/bottom-navigation#usage

bubelov commented 3 years ago

@Antoine-Derouin do you have any advice on that?

Atn-D commented 3 years ago

In many apps, the settings button is in the burger menu. But creating a burger just for this button is a really bad idea...

Can you offer several buttons?

Unread news All News Bookmark Feeds Settings

And put the burger in the header?

Or like TTRSS : The burger opens a panel with the settings button, then a list of feed folders, and an "unread only" toggle.

bubelov commented 3 years ago

@Antoine-Derouin thanks for the advice!

And put the burger in the header?

Just to clarify: do you mean the thing on the left or the thing on the right?

Screenshot from 2021-01-14 13-08-34

Atn-D commented 3 years ago

I'm talking about the left button.

I see the burger menu, with three lines like opening a general menu panel. (identical throughout the app)

.

The three little dot icon would make me think more about options specific to the current display. Like a context menu.

seldon1000 commented 3 years ago

@bubelov I would like to share some thoughts. I don't think adding a hamburger menu is a great idea. Google is gradually removing it from its apps as Material Design guidelines are evolving to better support long aspect ratios and side navigation gestures. Probably, what's best in this case is a Bottom Drawer, like a classic Modal Drawer but anchored at the bottom (it follows your app's style).

More infos: https://material.io/components/navigation-drawer#bottom-drawer

The link even mentions the possibility to add an account switcher (could be good for Nextcloud). However, the activation of the Bottom Drawer is tricky: a button on the top app bar would be inconsistent and inconvenient, while a gesture would interfere with system's navigation gestures.

bubelov commented 3 years ago

@seldon1000 bottom drawer is supposed to be used with bottom toolbar, not bottom navigation bar, used in this app. It's a replacement for toolbar at top of the screen, but we can't move it to the bottom because this place is already occupied by bottom navigation bar. There are no ways to merge those two things.

Here is how it looks and what it's capable of:

https://github.com/material-components/material-components-android/blob/master/docs/components/BottomAppBar.md

It can't replace bottom navigation, it just lacks those features.

bubelov commented 3 years ago

Closing because new navigation structure doesn't have this issue