search

buckaroo-it / BuckarooSdk_DotNet

Software Development Kit which can be used for easy access to the Buckaroo API.
MIT License
6 stars 18 forks source link

HttpClient scope #35

Open theo-albers opened 5 years ago

theo-albers commented 5 years ago

The Connection class creates an HttpClient and DelegatingHandler on every request. This is bad practice in a server environment like ASP.NET, see https://docs.microsoft.com/en-us/dotnet/standard/microservices-architecture/implement-resilient-applications/use-httpclientfactory-to-implement-resilient-http-requests. It would be very nice to be able to control the HttpClient or DelegateHandler lifetime as SDK consumer. Right now we can't use the SDK (or we would have to clone and modify the source).

buckaroo-it commented 5 years ago

Thank you for your suggestion. we will take a look at this as I agree with your point of view on this matter. I will at least provide you with the intended solution and the timeline to implement the fix. In the coming weeks we are short staffed and a change like this needs to be tested thoroughly. I will come back to you. greetings

jonassix commented 4 years ago

Hi,

What is the status of this?

stefankip commented 4 years ago

...

jonassix commented 4 years ago

...

Yeah, they won't respond. I've developed my own implementation faster than they are even able to respond

timvandenhof commented 3 years ago

Yeah, they won't respond. I've developed my own implementation faster than they are even able to respond

Can you open a PR for them so other can profit too? My current team is implementing Buckaroo at the moment, and this could hinder our performance as mentioned by Theo.

jonassix commented 3 years ago

I've written an entire code base from scratch. It's not a fork and it's not open source. So won't do a PR.

This library was very handy as a form of documenation. For how authentication works , how the message's are constructed. Imo the only "difficult" thing was the authentication. So my advice would be to just build your own implementation.