search

buckaroo-it / Magento2

Repository containing the Magento2 plugin by Buckaroo
MIT License
28 stars 35 forks source link

[BP-1898] Invoice email sending is forced to be non-async #638

Open igorwulff opened 1 year ago

igorwulff commented 1 year ago

https://github.com/buckaroo-it/Magento2/blob/90670f5e08e71482790ed7e2b41ca6fbaa0685cb/Model/Push.php#L1531

I'm curious if this is behavior that we really want. Apparently invoice sending through this module is directly being send when a push from buckaroo happens .Why not control this behavior by settings defined by Magento in regards to async/sync sending of emails? Its causing some issues for one of our clients, since in parallel a lot of push calls were being fired to Magento, with slow email generation on our side because servers got overloaded by traffic next to these heavy calls.

Buckaroo-Rens commented 1 year ago

Hi @igorwulff thanks for issue. We are indeed aware of this and already in process of refactoring this part of our code. Not only this specific part but the whole push file/logic is going to be improved, standardized en more easy to read/use. Unfortunately i don't have an hotfix for this right now but it's high on our list.

Please also check https://github.com/buckaroo-it/Magento2/issues/633 for some more info.