buda-base / blmp-client

JS client for the BLMP
3 stars 0 forks source link

use field as prefLabel #17

Closed eroux closed 2 years ago

eroux commented 2 years ago

In the cases of person and instance, there are two sets of names:

in the data they are independent, but it's not very convenient if they are independent in the UI, since 99% of the time the prefLabel will be one of the names / titles.

A proposal is:

This case will be detected with the bds:allowPushToTopLevelSkosPrefLabel true (not the most elegant name but...)

berger-n commented 2 years ago

done, I've also put type & label/language on one line to keep things compact for Karma: https://editor.bdrc.io/edit/bdr:P3379/bds:PersonShape

image

you can manually add/replace top level prefLabel for this language using button which appears on hover or automatically when closing property group/opening another (it will copy label if there isn't any for this language)

eroux commented 2 years ago

ah the one line thing works really well, thanks a lot!

I think the button could be improved a bit... I'm thinking of this icon, perhaps preceded by this one (or maybe a mix of the two a bit like this one ?). The text on hover could be "use as the main name or title for this language". Otherwise excellent, thanks!

berger-n commented 2 years ago

ok! tried something like that: https://editor.bdrc.io/edit/bdr:P3379/bds:PersonShape

image

eroux commented 2 years ago

that's a bit better! Let's change the button a bit more:

berger-n commented 2 years ago

updated icon/button:

image

eroux commented 2 years ago

perfect, thanks! maybe a bit more padding around the icons

berger-n commented 2 years ago

done:

image

eroux commented 2 years ago

good! let's move things around a bit:

berger-n commented 2 years ago

done:

image

eroux commented 2 years ago

ah yes, much better, thanks! now we should balance:

berger-n commented 2 years ago

done:

image

eroux commented 2 years ago

perfect, thanks!

eroux commented 2 years ago

just reopening for a little design issue, can we have the message ("use as the main name or title for this language") in a small tooltip like we do for the ? icons?

something like

Capture d’écran de 2022-03-02 15-56-40

berger-n commented 2 years ago

done:

image

eroux commented 2 years ago

perfect, thanks!