search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

BP Required version? #10

Closed imath closed 8 years ago

imath commented 8 years ago

Today, i've noticed we might need to add a new parameter to Template packs data: the required BuddyPress version.

For instance, in the BP Nouveau template i'm editing the Messages Subnav, and to avoid the notices, i use the 2.6.0 new nav...

mercime commented 8 years ago

I totally agree that we need to add the required BP version... as well as the WP version :)

I suggest that we should be working with BP/WP trunk versions until the official release. e.g. the required BP version at this time is BP 2.6.0 trunk, then after BP 2.6.0 is released, change the required version to BP 2.7.0 trunk. Then if work is not done by BP 2.7.0 release, change it to BP 2.8.0 trunk, etc. until the official release. It's similar to how the Twenty Sixteen theme was developed in Github - required the WP trunk version till the official release.

hnla commented 8 years ago

but ultimately this isn't a plugin or a theme is it?

How do we dictate what version is necessary, the current templates don't do this?.

As for dev in this sort of project we should be working to BP trunk, I always dev on BP trunk as it's seldom out of kilter enough to worry, and I'm running this template-pack on a WP bleeding edge install so trunk for both BP/WP

imath commented 8 years ago

here's why https://github.com/buddypress/next-template-packs/commit/b2de603fb4c1f8287c628d8dd8a23fafa13ffc14

If we don't include a required BP Version, people could use the template pack with a previous version of BuddyPress. For instance in the above commit, i'm doing a class check to see if it's 2.6.0..

imath commented 8 years ago

This is what i suggest, a new template pack header tag and if required version is not available, simply do not display the template pack into the UI to switch template packs.

See this patch https://gist.github.com/imath/3a1723de2304d81932fc0e6e35fd6d9d

hnla commented 8 years ago

here's why b2de603

ok claro.

The approach is sound , if your install does not report back a version we require then simply bail out and do not run the switcher or run the switcher but with message that new template packs require the latest version or #.# version of BP