search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Remove Colons - from label strings in dir customizer options. #100

Closed slaFFik closed 7 years ago

slaFFik commented 7 years ago

image

hnla commented 7 years ago

The options do work in respect of: Selecting column will place main nav to the left side . Selecting nav to 'Tab Style' will change the styles to look like a tabbed effect (thin border around active element.

Oddity is in Chrome this happens on selection i.e while selection is made 'transport = > 'postmessage' while on FF this appears to only kick in when saving and exiting the customizer.

@slaFFik Quite why this doesn't appear to be working for you local needs further investigation,, likely there are issues with the Customizers transport process which I'm no great fan of but the styles should eventually be kicking in.

slaFFik commented 7 years ago

Options are working fine when clicked, but I'm confused with a :. I suppose there should be additional "suboptions" under each one with a colon. Am I wrong? If yes - then colons looks weird here and imo should be replaced with dots.

hnla commented 7 years ago

Remove colons they are superfluous here!

slaFFik commented 7 years ago

Forgot to include fix #100 into a commit message :( Done in 70228043ea77bb43574a907bd1f1906f87419cbf Closing this issue.