search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Naming conventions & file locations & tooling #109

Closed hnla closed 7 years ago

hnla commented 7 years ago

This ticket is to bullet a number of areas to discuss & sign off on that covers how we name directories and /or files and where files are located, plus tooling i.e unit tests also it can note any queries that might arise while considering the file structuring

Points to review/discuss are whether we're happy with and that these make sense ( by & large I consider that they do):

Under _accessoires ( which I think we agree needs renaming) we have essentially backbone templates with associated js files in /js/

paulgibbs commented 7 years ago

@hnla can we merge accessories into common?

hnla commented 7 years ago

As common/_accessoires/ ?

we could do with renaming it wherever it ends up being located.

Not sure of the hassle moving this dir but we can explore.

paulgibbs commented 7 years ago

Just seems silly to have three directories that sort of do the same thing, like you pointed out here originally. 🤡

Paul Gibbs

On 26 Jul 2017, at 13:54, Hugo - hnla notifications@github.com wrote:

As common/_accessoires/ ?

we could do with renaming it wherever it ends up being located.

Not sure of the hassle moving this dir but we can explore.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

hnla commented 7 years ago

Agreed, problems are ... if moved to 'common' are these really common files they tend to belong to one item however re-thinking, not that concerned really.

If it's moved lets rename it, but to what? Open to suggestions, have no views really other than 'backbone-templates', 'js-templates' something along those lines?

paulgibbs commented 7 years ago

I don't think it matters what the folder contains. /assets is used in bp-legacy for things like the email templates (right?), so let's move "accessoires" into `/common. ?

hnla commented 7 years ago

yep currently doing so but need confirmation on naming have renamed dir to js-templates and moved into common agreed? oh and dropped the leading underscore.

paulgibbs commented 7 years ago

I don't care too much. up to you, you know what's in teh folder.

hnla commented 7 years ago

js-templates leaves it slightly agnostic rather than backbone-templates establishes what the folder structure is for not what type of file must be there.

hnla commented 7 years ago

Closing.