buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

ARIA roles used must conform to valid values #112

Closed mercime closed 7 years ago

mercime commented 7 years ago

"content" is not a valid ARIA role value per <div class="screen-content" role="content">

Instances found:

WCAG 4.1.2

hnla commented 7 years ago

Think that was meant to be 'main' might have been me having one of those 'moments'! :)

hnla commented 7 years ago

It was a blond moment on my part I had been intending that to be role="main" but had 'content' stuck in my head - can we consider adding role 'main'?

mercime commented 7 years ago

We could add data-content="main" if that works for you. We removed the role="main" from our BP template files because WP default themes and others already have that role (BP#6456).

hnla commented 7 years ago

WP default themes and others already have that role Ah right and why doing this sort of template/theme exercise is sort of frustrating - lets leave then as you've done in 'removed'.