search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Replace buddypress with buddypress-wrapper in bp_nouveau_buddypress_classes() and use it in style sheets #120

Closed mercime closed 7 years ago

mercime commented 7 years ago

We already have a buddypress class generated in the <body> tag. By changing the class from buddypress to e.g. buddypress-wrapper in bp_nouveau_buddypress_classes() for the div surrounding the BuddyPress templates, we make clear what element we are manipulating without having to resort to adding additional selectors.

For example, instead of using body.buddypress, we can just use .buddypress because it's the only one generated in the stylesheet. In addition, instead of having .buddypress .buddypress ul { ... } it could be simplified to .buddypress-wrapper ul { ... }

hnla commented 7 years ago

Actually this ties in to comments I made in the _bp_buttons.scss about the main classes.

It's a good idea we'll change at some point.

mercime commented 7 years ago

I haven't had a chance to read comments in Sass files, but good to know that the class will be changed 💃