search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Remove inline styles, specially display:none #122

Closed mercime closed 7 years ago

mercime commented 7 years ago

Applying display:none to any element in the markup makes the element inaccessible to users of screen readers.

We can either add the class .bp-screen-reader-text to that element or add a new class, without display:none in the declaration of that new class, as a hook which can be manipulated via JavaScript.

Related to #117

hnla commented 7 years ago

First pass look:

Addresses bp search form.

Updates the js to use class hooks.

Updates styles to add classes and properties to position off screen (these are kept as a separate approach from the screen reader text class)

As Nouveau technically doesn't work without JS not making too much effort on disabled JS other than to re-instate the show properties to ensure the search submit is visible.

hnla commented 7 years ago

With the commit of show/hide rulests and updates to some actions where there was the use of jQuery .hide() tackled we'll close this ticket and open fresh ones if necessary for further instances where JS needs updating.