search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Buddypress-functions.php, lightening the files work #18

Closed hnla closed 8 years ago

hnla commented 8 years ago

Prompted by creating a new include file which then became a template tag function needing a home.

The BP functions file currently seems a little bit jumbled and hard to navigate through.

Originally we never had Ajax functions in this file or iirc any general functions.

I propose thinning this file out.

Ajax functions should return to their own file.

A new file created to hold general template tags / functions.

imath commented 8 years ago

So first we're kind of stuck with the buddypress-functions.php name as core is requiring us to use this name in bp_load_theme_functions(), see https://buddypress.trac.wordpress.org/browser/trunk/src/bp-core/bp-core-template-loader.php#L566

But, i think reorganizing this file by splitting it into smaller files can be done, and should be! We only need to use this file as the bootstrap and add an includes() method to the BP_Nouveau class.

According to our last "tp-chat", i will also get rid of the bp-custom.php file and include another one in the method i was talking about at previous paragraph. I just want to point the fact that if i used this file that was because it was a practice done into the "BuddyPress templates" template pack see https://github.com/karmatosed/buddypress-templates/blob/master/bp-custom.php

So i'm going to start a new branch to work on this asap.

hnla commented 8 years ago

yep buddypress-functions.php shouldn't change this is a proscribed file, but should have less in it!

and yes to those other points of yours above.

Main thing is Ajax back to it's own file like it used to be , and a new file for generally providing any functions or template-tags whatever we call things like that.

Yep sorry had forgotten bp-custom.php was in the old template pack but then as now I felt it was odd.

hnla commented 8 years ago

Bon!