search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Function escaping in template functions #186

Closed paulgibbs closed 7 years ago

paulgibbs commented 7 years ago

The first thing I wanted to do was removing the early escaping from the "get" template-tag functions, so I picked on the template-tag files within each folder, and went through.

Code quality was generally between "acceptable" to "good", and I'm happy to discuss any specific questions these proposed changes might raise, but for brevity, I've left that kind of reply out this request.

hnla commented 7 years ago

Paul I've scanned through all these files and changes and they all make sense to me ( excepting the one mentioned ) I would merge when your happy.

hnla commented 7 years ago

Ignore this comment the one above didn't seem to appear initially.

Made a comment against a line where I built a function to truncate group decrip if in a grid layout, it seems like the grid layout check was removed but may have read the changes incorrectly. groups/template-tags.php L: 1348