search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Small improvements to `img alt=` tags, indentation, and i18n. #193

Closed paulgibbs closed 7 years ago

paulgibbs commented 7 years ago

Everything else in the actual templates looks acceptable.

I've not finished the many PHP utility files yet.

paulgibbs commented 7 years ago

I disagree 100% about the entire bp tooltips thing - I think that entire feature is of questionable benefit - but removing the title tags needs to happen. It's against best practise for accessibility.

Paul Gibbs

On 17 Jul 2017, at 20:13, Hugo - hnla notifications@github.com wrote:

@hnla commented on this pull request.

If title attr are removed we should replace with data-bp-tooltips.

In screen reader text we should not use abbreviations which are a visual cue and aren't actually pronounceable e.g 'prev' is not a word, 'previous' is.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

hnla commented 7 years ago

I disagree 100% about the entire bp tooltips thing - I think that entire feature is of questionable benefit

Can't help but wonder then why we've done them on bp-legacy?

Merging your PR - thanks.