search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Feedback messages - group create, form errors #200

Closed hnla closed 6 years ago

hnla commented 7 years ago

This feedback message is managed by nouveau templates, has a dismiss button, why!

In template-tags.php : 'bp_nouveau_has_dismiss_button() In includes/functions.php:$feedback_messages`

The form error is managed in \BuddyPress\src\bp-groups\bp-groups-actions.php

We don't seem to be able to override this and we should manage this from Nouveau like all other messages, yet appear to be fetching this message from BP core and not then setting the message $type.

For the moment the dismiss button boolean test is returned 'false' for group create test steps, not a good hack!.

hnla commented 7 years ago

Re-work approach. Now add separate additional check for $bp_nouveau->user_feedback['dismiss'] and re-works the template_message checks to test for new key template_message['dismiss'] set when we fetch bp template messages for nouveau testing on the message type i.e setting 'bp-sitewide-notice' to true.

hnla commented 6 years ago

Closing