the common/filters/component-filters.php is missing some filters and could probably be improved

buddypress / next-template-packs

is this the next BuddyPress template pack?

35 stars 9 forks source link

the common/filters/component-filters.php is missing some filters and could probably be improved #24

Closed imath closed 8 years ago

imath commented 8 years ago

Activity and blogs filters are missing.

I wonder if we could simplify it a bit like i'm suggestion for the directory nav on #16 (but without using a nav of course :) )

hnla commented 8 years ago

Probably, even if not we improve things by only having the one set of markup to deal with, but all aspects like this need that further detailed look, these are first passes that lay things out so to speak.

btw thanks for filling in the missing filters.

imath commented 8 years ago

The above commit is my suggestion to improve directory nav so that the template is simplified. You can compare common/filters/component-filters.php with common/filters/directory-filters.php.

If @hnla is Ok with this i'll remove common/filters/component-filters.php else, i'll revert the commit.