BP Nouveau & group invites/member messages templates.

[imath]

BP Nouveau is using specific Javascript UIs with JS templates for group invites and the private messages of the members meaning, it doesn't use at all what's in the /members/single/messages directory and is not using groups/single/invites-loop.php template.

Should we keep these templates ?

[hnla]

I'm a little concerned to remove them, but this partly comes from my intent that templates are always templates are templates in other words somewhere we have this stock default set of templates that serve to initiate all necessary screens, Legacy templates needed and need improving I would want to do thi,s update improve those, files but then we need somewhere for them. If template packs do very unique things (regardless of how good) we have what are more proprietary sets of templates changing between packs possibly quite dramatically so could end up with situation where it was hard to find that de-facto set if one were looking for a complete series.

I'm inclined to think that we should not delete them, although it could be said to be confusing having them in place although not used.

[imath]

I think we have two options.

Keep them and let people choose not to move forward with our new UI. eg: a new section in the customizer to disable the invites/messages/activity post form UI... (which will give us more work to maintain)

Or move forward with our new UIs and drop these unused templates :)

I'm ok with both, we just need to make a decision. What we can't do is leave them in place and do nothing with it.

[renatonascalves]

Or move forward with our new UIs and drop these unused templates

I understand @hnla point but I think removing is the best course of action. I don't see why would I want unused files.

BuddyPress could advertise, as it always do with possible breaking changes, about its removal.

[BoweFrankema]

I agree.. No point in keeping unused template parts around :-)

[hnla]

But have you considered my points? You have to have templates that are a stock set or that may be considered a stock set, are we to say those are bp-nouveau? If that theme becomes very unique and proprietary how useful are those templates when a dev comes to needing a set to build a client site from or do we expect them to have to build from ground up.

I think that whatever we do we should move these template files to a directory on bp github that simply stores them, and where if people want them they can copy them from there. Drawback to this though is really this would need to be full sets, odd files will seem strange.

[imath]

They can always copy them from BP Legacy :)

I've considered your points. And i'd say why not. But if we are to keep these templates, they must have an utility. That's why i've suggested to use them as fallback to our new UIs. Meaning we would make these UIs optionnal. A new section called "Modern Layout or UIs" in the the customizer could help people to choose if they prefer to deactivate them.

[mercime]

If we're going with " Javascript UIs with JS templates" all the way, then I recommend we remove the old templates. Don't let those templates bog down the bp-nouveau coolness.

Beyond this, if javascript is not enabled, then fallback to bp-legacy :)

[hnla]

They can always copy them from BP Legacy :)

then fallback to bp-legacy

Please, unless someones prepared to update bp-legacy templates, they shouldn't really be touted around as something that should be used going forward. they exist simply cos they existed, given half the chance I would trash them.

[hnla]

However as the consensus is to remove the templates lets do so , but can we squirrel them away somewhere if they have changes, although they probably don't and are simply copies of bp-legacy in which case there's no point in retaining so we just delete!

[imath]

I've just check only differences are the domain name and some templates of the messages component are outdated considering BP Legacy. So i'm going to remove these files. Thanks a lot for your opinions.