search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Profile edit template & field visibility functionality #50

Closed hnla closed 8 years ago

hnla commented 8 years ago

Commit adjusts some simple positioning, moving things like descriptions and visibility toggle elements around for better layout.

On the visibility settings include members\single\parts\profile-visibility.php it struck me that we're wrapping markup in translation strings, unpicked that so the span markup is outside but not sure if I have added the function in correctly to enable translation e.g: <?php printf(__('%s', 'bp-nouveau'), bp_get_the_profile_field_visibility_level_label() ); ?>

Could that be checked and adjusted as necessary.

imath commented 8 years ago

I've checked and i'm going to put it back the way it was, and the way it is in Legacy. You're wrong there's no html tag into the translation string. The markup is added to it by printf at run time and imho it makes no sense to simply use __( '%s' ) and i'm pretty sure splitting a string the way you're doing will generate issues with some languages like russian etc...