buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Remove user update text from loops #55

Closed hnla closed 8 years ago

hnla commented 8 years ago

This piece of user meta is one that causes extreme angst in a box paradigm type layout of loops.

Elements of unknown data cause issues where attempts are made to have uniform visual presentation, forcing a lot of unsatisfactory min-height, assumptions that if empty we force height so other elements line up etc, yes there are various workarounds, none are ever 100% satisfactory.

Lets remove the bp_member_latest_update() altogether and have a far neater manageable grid box ( I have just tested a four column grid with one member having full update text displayed and it's unworkable at slightly narrow widths or any widths frankly) alternatively we run a new truncation value if the grid is in operation for a loop and ensure that the meta is suitably short even though this still means having to force empty space height where meta isn't displayed.

imath commented 8 years ago

You'll have the same problem with groups & blogs loops.

I believe, we can keep these when layout is default, and not display them if the layout is 2, 3 or more columns. What do you think?

We could have a template tag check like:

if ( bp_nouveau_loop_is_one_column() ) {
     bp_member_latest_update();
}
hnla commented 8 years ago

I believe, we can keep these when layout is default, and not display them if the layout is 2, 3 or more

Sorry I wasn't clear but yes exactly as you say above is what I was thinking. We offer explicit and special styling but that comes with conditions, boxes don't handle dynamic data rendering well so we manage what's displayed, if just wanting the default running list style then we can display all elements.

And yes I too was thinking a template tag was going to be needed - I tend to always build conditional tags for running checks so think we ought to have them available for any function or condition that might change in templates, maybe along the lines of bp_nouveau_loop_is_grid() returning true or false but as true returning the selected columns? so we could check as if( 2 === bp_nouveau_loop_is_grid() ) or return an object or whatever.