search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Font Sizing and options,choices #58

Closed hnla closed 7 years ago

hnla commented 8 years ago

It's with reluctance that I'm deciding on having to re-factor the font-sizing mixin I added from the companion styles , while it suited those sheets as I could adjust the params to suit the parent themes body font size adjustments in this temp pack paradigm I cannot know this value thus can't render accurate rem sizes ( if a theme drops body to 10px == 1rem all well and good if it leaves at 100% we will get text at too large a size)

We do have need of managing certain elements in various places, I've tried keywords before in buddypress.css styles with mixed to poor results and in general they are not refined enough for purpose.

I'm going to reset the mixin to output only pixel sizes for the moment to see how that works out.

I'm interested in thought around the issue though?

mercime commented 8 years ago

Suggest continue to use pixels with rems. At the very least, theme devs can adjust font-size to fit their designs.

hnla commented 8 years ago

I might add back the rem component of the mixin later but at the moment this is a puzzling aspect for too many reasons. Leaving this ticket open while the issue remains in limbo.