search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Messages bulk select checkbox #65

Closed hnla closed 7 years ago

hnla commented 8 years ago

I think we need to remove this element from this current position. Since the change the positioning in the subnav ul makes it hard to style & manage the positioning and really the element should live with it's child elements so in or close to the bp-messages-content element.

imath commented 8 years ago

Ok, i'll see how i can change this :)

imath commented 8 years ago

Looking at it, it will be weird to have 2 toolbars. One to search and paginate, and the other one for the bulk actions.

What is annoying ? The fact the Apply button goes left and before the select ?

For now i will see how i can use buttons instead of links so that they can include the span.dashicon in it (just like i did for the search button).

hnla commented 8 years ago

What is annoying

Look at the flow it makes no sense, you have a disconnect now between a control and it's intended action, the control needs to be more within the context of it's sphere, but yes in essence it could be mildly improved if the bulk select came last, it's the more natural order.

It's also a little difficult to style but that should not be simply the sole reason, markup flow and general semantics is the first concern always.

I see no reason two toolbars are an issue, toolbars are not a 'thing' they are artificially created by us it's just an element and can be as simple as a div to hold the element.

I'll look again at the styling issues but it was something that on first glance proved troublesome to deal with and felt limiting in what one could do.