search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

BP body classing #70

Closed hnla closed 7 years ago

hnla commented 8 years ago

We need to modify the body class buddypress that BP core adds. In trying to be good and only namespace our rulesets under .buddypress, instead of #buddypress we inadvertantly aply rules to theme elements outside our namespace - as it's on body and our own child element. If I revert to using #buddypress in places it then affects elements such as search inputs upsetting their display - constantly dancing back and fourth trying to catch issues and update styles is an annoyance.

Changing the body class seems the sensible approach, doubt we have used it, thus changing via JS via hasClass removeClass then adding ? buddypress-active instead.

imath commented 8 years ago

What about "nouveau" i'm pretty sure we will never have this kind of problem with a french word!

hnla commented 8 years ago

Only as I would probably really want a generic type token that does give a top level easy hook for a BP screen. If styles are hooked to this point and they are of a default nature i.e living in a partial file that would be used for base styles we need a common string that doesn't change from TP to TP.

However not too bothered but if going with TP name then pre-pending 'bp-' might be clearer?

I think I avoided issue for the moment by using .buddypress . buddypress .my-class {}

On 04/08/2016 09:43, imath wrote:

What about "nouveau" i'm pretty sure we will never have this kind of problem with a french word!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/buddypress/next-template-packs/issues/70#issuecomment-237490928, or mute the thread https://github.com/notifications/unsubscribe-auth/AAee29figvcywnA4HljFDP7P4H-gwlhgks5qcaZEgaJpZM4JbcIa.

No virus found in this message. Checked by AVG - www.avg.com http://www.avg.com Version: 2016.0.7690 / Virus Database: 4627/12743 - Release Date: 08/04/16