buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

search & filters are not technically navs. #72

Closed hnla closed 8 years ago

hnla commented 8 years ago

For a long while styling or struggling to style BP nav elements has always been difficult due to the way BP seems to add various disparate elements into the mix, one can get easily confused between screens as to what is being rendered in given parent elements leading to badly described rulesets countermanding others.

This has figured again for me with single groups/users screens and search filters that are the only items yet are rendered in the subnav parent, yes we can twist and bend all the classes to test conditions and get very convoluted hard to follow rules or we can remove the subnav wrapper(unnecessary) and treat these elements as they should be separately.

Where I identify we only run search/filters I'm removing the subnav wrappers - this may have consequences not thought of but we'll try and deal with these as we come to them.