buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Notifications - settings for email not... #73

Closed hnla closed 8 years ago

hnla commented 8 years ago

We're talking about the user settings screen for managing email notifications.

The issue is needing access to the tables and/or markup generally.

Another reason I dislike do_actions!

I get the reasoning and if all elements of a site build under my control would do the same however it's not.

It's hard to deal with this I grabbed members messages_screen_notification_settings() bp-messages/bp-messages-screens.php but of course now need to grab all other component instances in the other bp-*screens.php files.

I don't simply want to replicate the BP approach with each table in respective include sections added to the do_action but not sure what other approach is viable at this moment.

imath commented 8 years ago

The problem is actually wider. Because a lot of plugins are adding custom settings (tables) in this member's screen.

Could you describe exactly what you need, like adding classes to the tables etc.. Because i'm not sure PHP is the right choice here. Maybe we could add classes using Javascript?

hnla commented 8 years ago

The problem is actually wider

Yep I knew this a fair while back, it was one of those items I'd marked to look at but like others the way in which we had approached these elements in core meant a struggle to unpick and run in a better manner i.e markup in a template position.

Maybe we could add classes using Javascript?

Although this is definitely not simply about classes or indeed just about some visual styles I had considered this and yes it's easy to hack away using JS, but that is just that a hack and not really the elegant solution.

It is a php issue or at least a construction issue, my focus is always to try and look at where core has acted like a finished app and added frontend markup in files inaccessible to the front end and try and find a means to bring that out or ensure it is accessible.

So not sure how to go about dealing with this, feels like too many problem which makes me very sad.