search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

General & random naming conventions #9

Closed hnla closed 8 years ago

hnla commented 8 years ago

We have general naming issues as I perceive things, or tokens/labels that have always bothered me, as those are crossed I'm listing just to prompt discussion on something better or to act as aide memoir.

hnla commented 8 years ago

item-list-tabs

Is one we need but frankly this string has never meant anything to me and holds little semantic value, 'tabs'? that describes a style, there are seldom tabs and regardless we don't know what they might be styled as . 'item' ?? Item is very vague - 'list' ok yes it's a list!

imath commented 8 years ago

I'm using item-list-tabs in javascript! Actually in one place. i'm not against, i'd say i second your point we just need to be careful i suggest to use the strategy i've been using so far by using data attributes like data-bp-role="primary-nav" or data-bp-role="secondary-nav" when it's used as a secondary nav :) So we'll need to choose the best token, put the data attributes in templates and update JS.

hnla commented 8 years ago

I thought we were going to use data attr for the majority of JS requirements, where possible. My problem with hooking to existing classes is that we must first determine if they are valid or could do with updating, and that along with updating markup has to be a core task in this project otherwise we'll never take the opportunity to do this and always shrug and build on things that ought to be changed, never reaching those clean templates tha represent those that we can say are best to use, copy etc.

hnla commented 8 years ago

Closing in favour of #61