search

buddypress / next-template-packs

is this the next BuddyPress template pack?
35 stars 9 forks source link

Xprofile default visibility settings #91

Closed hnla closed 7 years ago

hnla commented 7 years ago

In profile edit & registration screens we check whether users are permitted to update the visibility of profile fields as set in the dashboard by admins.

In fixing some issues in 2.7.2 we regressed this check for anonymous users registering on the site by allowing fields set to 'disabled' by admins not correctly being checked and having the dropdown radio selections enabled when they should have been hidden.

BP Trac Ticket: https://buddypress.trac.wordpress.org/ticket/7391

Attempts to correct this with two approaches:

1/ Create a new function to check the enforced setting and replace the template bp_current_user_can() check with that simpler more direct check

or

2/ Update the function in bp-xprofile-caps.php that sets the logged out user capability by giving it a further check for vis fields (currently lacking)

BP will probably have to preserve the original function as editing the template will have backpat issues however Nouveau could update to a new function that better reflects the nature of the check and that doesn't muddy this by reference to caps checks.

This is a note to follow up when we've decided how to proceed with the core BP files.

hnla commented 7 years ago

Closing this the solution committed in BP core (2.7.4) will work for us, no real reason to bypass the caps checks in favour of simpler template tag checks.