budtmo / docker-android

Android in docker solution with noVNC supported and video recording
Other
8.8k stars 1.19k forks source link

Fixed docker container stop/start blank background error #403

Closed enrey closed 2 months ago

enrey commented 5 months ago

Types of changes

Purpose of changes

When doing docker stop then start, getting blank background instead of emulator and error in logs: sudo: unknown user: root sudo: unable to initialize policy plugin ... subprocess.CalledProcessError: Command 'sudo chown 1300:1301 /dev/kvm' returned non-zero exit status 1.

Related issues: https://github.com/budtmo/docker-android/issues/365 https://github.com/budtmo/docker-android/issues/373

enrey commented 5 months ago

Hope this not breaks compatibility with other enviroments. I suppose that we don't need second chown after container was allready created and initialized. Fix works for me on Win 11 / WSL2.

RasmusDK commented 5 months ago

thank you, if this will fix it 🙏 Have been an annoyance for months now.

budtmo commented 2 months ago

Thank you for the PR @enrey . sorry that it took so long to review.

budtmo commented 2 months ago

I need to revert the change as it breaks the code. will investigate it later