Add build for armv7 buf binaries

nimish-ks commented 2 weeks ago

This PR adds coss-compiled build support for linux arm LE linux armv7l architecture, used by some of the older ARM devices such as the raspberry pi.

      - name: setup-qemu
        uses: docker/setup-qemu-action@v3
        id: qemu
        with:
          # alpine image doesn't support linux/riscv64
          platforms: linux/386,linux/amd64,linux/arm64,linux/arm/v7,linux/arm/v6,linux/ppc64le,linux/s390x

I can see that linux armv7 support already exists in the ci.yml file. Do I need to make changes elsewhere?

This will also fix some downstream issues such as: https://github.com/usememos/memos/issues/3306

CLAassistant commented 2 weeks ago

All committers have signed the CLA.

nimish-ks commented 2 weeks ago

If these changes are merged, this will not be in effect until the next release and would also not be applied to old releases, so in order for downstream services like memos to pick this up, they would need to update to the release when it becomes available.

I understand. Looking at the pace of the last few release cycles (few weeks to a month), I don't believe It would be a long wait. :)

This is for our Docker images and should not affect your use-case.

Cool.

However, based on what I'm seeing in memos, they use buf to manage the generated code for their proto API definitions and they manage buf through npm/pnpm. So we'll also need to update the binaries available to our NPM packages if this merges.

Yes, thought so too. It it this one? https://www.npmjs.com/package/@bufbuild/protobuf

nimish-ks commented 2 weeks ago

Before I approve, could you please pull in the latest main and merge to the PR?

I believe I already have in - 1633130. Please correct me if I am mistaken.

bufbuild / buf

Add build for armv7 buf binaries #3450