buff0000n / mandascore

Display app for a Mandachord song code
MIT License
32 stars 1 forks source link

Feedback #2

Open buff0000n opened 3 years ago

HirotaZX commented 3 years ago

Hi, Buff00n. I found that the volume values in below code are saved in half precision floating point, which is not supported by javascript natively. @petamoriken/float16 should work in browsers. The unit of this value is decibels that can be convert to levels, this post should be helpful to implement the conversion between them. Hope to see the perfect volume adjustment, and thank you for creating such a great tool!! :smile:

var vol_p00 = 0xD1D2;
var vol_p25 = 0xCA00;
var vol_p50 = 0xC5FD;
var vol_p75 = 0xC09C;
var vol_p99 = 0xAD00;
var vol_p100 = 0x0000;
buff0000n commented 3 years ago

Huh, it never even occurred to me that it's in -dBFS. Thanks a lot! Still, -46.5625 dBFS strikes me as a pretty weird and arbitrary zero level.

Oh, I just noticed your Mandachord app. Sorry, I know how it feels when people say this, but I had no idea it existed. It's too bad pasting song codes into the in-game chat window stopped working.

buff0000n commented 3 years ago

@HZDeluxe I got it implemented now, thanks for your help!

I also fixed it in my OCR program and updated about 1300 songs in my local song database that had volumes below 100%. It's going to take about a week to update all those Mandascore links on my videos; YouTube API quotas mean I can only update 200 video descriptions per day.

HirotaZX commented 3 years ago

@buff0000n I didn't expect that you would update your songs. You are amazing! :thumbsup:

DestrockQc commented 3 years ago

Hi, I made a song with the help of your website. Thx for this it help a lot ! DE will have to help octavia cause it is very hard to cast our skills when we don't use every notes in the metronome and even then the sprint boost is almost impossible to cast but at least someone made an helper for making songs :D I don't know if you add the player songs in your library but if that's the case you can add mine. Title : DestrockQc 2 link

: [SONG-Omen:AAC/UsDEhAoABQZABBCgAQRIAICMACAnAAQQkAEEcAEgiIAIJhABBIQAQUQAEIkABCZABEDAARBkAYEKAARGQARAoAEQSACBDAAgRwAEIJABCHABIIiACCYQAQSEAEFEABEJAARGQAQgwAEIZAE=:BardCorpusPackC:BardHipHopPackA:BardGrineerPackB]

And btw, your helper bugged a couple times. I had to save the links in notepad just in case and when it bugged I was able to copy past it inside a new tab and continue my work. If you could make it possible, from the "clear copy past play" section to copy past it from one tab to another it could be a faster workaround for when it bug and at the same time we could try some different mixes in 2-3 tabs at once. We some time have to try something new see if its better and then decide if we keep the old work or continue on the new. By copy pasting sections it would save time and always do a backup in case we are in trouble. An autosave would also be nice. And be able to move/swap the 4 block (8 parts) instead of always copy pasting would save even more time. Maybe an option to reverse the notes (I mean like in a mirror) could help our creativity. ANNNDDDD finally, thank you ! hehehe overall it work well :P

buff0000n commented 3 years ago

@DestrockQc

your helper bugged a couple times

How exactly did it bug out? Do you have some way to make the bug happen reliably?

copy paste it from one tab to another

You can copy the contents of the 'Song Code' box at the top into the same box on another tab. You can also use the 'Playlist' function to have different versions of your song in the same tab.

copy pasting sections

Yeah, I've also been pining for some more copy options, too, especially between songs in a playlist.

An autosave would also be nice

I should be doing the same thing I do in DojoCAD where it updates the URL bar every time you make a change, but that's the best I can do for an autosave.

move/swap

reverse the notes

Yeah, I got tons of ideas, too. The problem figuring out a way to put that kind of stuff in there without making the UI a cluttered, indecipherable mess.

DestrockQc commented 3 years ago

Oh you answered fast no time to come edit lol

"How exactly did it bug out? Do you have some way to make the bug happen reliably?"

Well it bug randomly. I often switch instruments for finding the best, and when it load I some time have a red text message and I have to continue on a new tab...

"You can also use the 'Playlist' function to have different versions of your song in the same tab."

Ahhhh yes I see now. I was sure it was only for your big library. We listen a couple and keep the ones we prefer then recheck our favourite list see which one we want to add in game.

The reason why I wanted to edit my other message : I forgot to say this : we absolutely must be able to listen the bloc 1 and/or 2 and/or 3 and/or 4. Not only 1 OR 2 OR 3 OR 4 OR all. The way I work is I listen the whole track and I repeat it many times in my head and when I know a note is bad somewhere I need at least 2 blocs, some time 3, but 4 is a waste of time for nothing. Especially since the music auto repeat itself no stop this is easy to add or remove a note, change one, and immediately hear the change. When we have to wait 4 blocs it confuse us a bit and take time.

Ah and when I save the image, I open it with paint and add yellow numbers 1 to 16 on the top of each sub-blocs. I find it easier this way for making the song in game. If the grey 1 2 3 4 would be more visible and replaced by 1 to 16 I would not have to do this.

buff0000n commented 3 years ago

@DestrockQc

Well it bug randomly. I often switch instruments for finding the best, and when it load I some time have a red text message and I have to continue on a new tab...

Are you selecting an instrument set and then somehow selecting another one before the first one even loads? There's definitely a bug with that, but I had to throw a delay in the code to even see it. It's fixed now.

If that's not it, then can you send my the contents of the red text, or more details on what you're doing when you get the error? It would also help if you know how to open the javascript console and see if there's an error there.

Ahhhh yes I see now. I was sure it was only for your big library.

Honestly, the playlist feature is mostly so I can do stuff like this https://www.youtube.com/watch?v=npoOE4uBDZc

we absolutely must be able to listen the bloc 1 and/or 2 and/or 3 and/or 4. Not only 1 OR 2 OR 3 OR 4 OR all.

I've thought about putting in some kind of timing bar above the note grids that lets you adjust the play range, but it's tricky with how I've built the note grids. At the very least I want to allow you to click and drag the playback cursor.

Ah and when I save the image, I open it with paint and add yellow numbers 1 to 16 on the top of each sub-blocs. I find it easier this way for making the song in game.

My primary goal was to make it match the in-game visuals as closely as possible, but a high-contrast version is not a bad idea.

DestrockQc commented 3 years ago

I just tried crashing your website while recording but it doesn't crash lol. And when I change instruments it's faster (is the speed based on the time of the day with the amount of users ?)

Edit : I wont come see future replies, I'm uninstall this shity game. It crashed in my face too many times and we can't play without having a bug every 5-15 min.

Nicolas-GE commented 2 years ago

i fount the Plogg instrument's volume very loud compared to the others... maybe there's some but or EQ that's needed to be done?

buff0000n commented 2 years ago

i fount the Plogg instrument's volume very loud compared to the others... maybe there's some but or EQ that's needed to be done?

@Nicolas-GE If you're talking about the Plogg bass, it's just loud. I usually cut its volume in half when I use it for a song in game. Otherwise, it's sampled from the game in exactly the same way as the rest of the instruments.