search

bugaevc / wl-clipboard

Command-line copy/paste utilities for Wayland
GNU General Public License v3.0
1.62k stars 60 forks source link

2.0 beta musl build problems #58

Closed stacyharper closed 5 years ago

stacyharper commented 5 years ago

Hey there !

wl-clipboard got problems with the void linux autobuild travis job on musl env.

https://travis-ci.org/void-linux/void-packages/builds/585446834

That why betas exists I guess ;)

bb !

bugaevc commented 5 years ago

Thanks for the report!

Looks like it's unrelated to musl — we weren't passing a strong enough dependency info to Meson. Please try whether https://github.com/bugaevc/wl-clipboard/commit/5b595cf9af5b6c0e89d5f5376fc250dde015fc2a fixes it.

stacyharper commented 5 years ago

I got some difficulties to run in the exact same context cause void-package rebuild from the tar.gz so we require a tagged version.

But, I got another pc running voidlinux on musl. I tried to meson then ninja master and I got similar problem. I tried your patch after removing the build dir and it seems to works !

Could you beta2 to try the production way ?

bugaevc commented 5 years ago

Yeah, I'll do a beta 2 later today when I fix & merge all the other stuff that came up 😀

bugaevc commented 5 years ago

Please let me know how it goes :)

stacyharper commented 5 years ago

Arf ! It goes bad x) https://travis-ci.org/void-linux/void-packages/builds/585698638

stacyharper commented 5 years ago

Maybe I missed a dependency. It seems one of the error is bout xdg.

bugaevc commented 5 years ago

Argh, no, it's my fault, I forgot to add the header dependency in the executables themselves.

bugaevc commented 5 years ago

Here's the fix. Looks like there's nothing else I could forget to add the dependency to :wink:

stacyharper commented 5 years ago

Does this solve https://travis-ci.org/void-linux/void-packages/jobs/585698645 too ? It seems a very different problem

stacyharper commented 5 years ago

(Ok I get the exact same issue on my other laptop. I'll be able to test this easier next time)

bugaevc commented 5 years ago

It doesn't; that problem is certainly unrelated to wl-clipboard, it's something void- or travis-specific.

stacyharper commented 5 years ago

Yeah I had a look and it seems like a shitty bug. Anyway thanks a lot for this ! :) Have a nice day/night. I'll test soon the beta3 and be back here to cry again ^^

bugaevc commented 5 years ago

I'll test soon the beta3 and be back here to cry again ^^

I'm not sure I'll a do a beta3 (sorry!) unless enough fixes/tweaks come up. But — did you know that you can get tarballs off GitHub for any commit just like this?

https://github.com/bugaevc/wl-clipboard/archive/09a76e0a93b4bef4bc81b5602dcf9dd66d466358/whatever.tar.gz

stacyharper commented 5 years ago

Yes ! That is the trick I need ! :DD Okay I test this now !

stacyharper commented 5 years ago

It works !

bugaevc commented 5 years ago

Yay! :smile: