search

bugsnag / bugsnag-js

JavaScript error handling tool for BugSnag. Monitor and report JavaScript bugs & errors.
https://docs.bugsnag.com/platforms/javascript
MIT License
858 stars 252 forks source link

Hotfix: promise rejection configuration #2239

Closed gingerbenw closed 1 month ago

gingerbenw commented 1 month ago

Goal

Ensure reportUnhandledPromiseRejectionsAsHandled config options is correctly handled and tested in react-native

Testing

Add unit tests for react-native to ensure configuration (and typescript definitions) handle new config value

github-actions[bot] commented 1 month ago

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 45.89 kB 13.78 kB
After 45.89 kB 13.78 kB
± No change No change

code coverage diff

<_temporarily disabled_>

Generated by :no_entry_sign: dangerJS against 14a93ed3a24174d64765be60189e348a98ce2cd3

yousif-bugsnag commented 1 month ago

is there a reason we haven't added a scenario for React Native?

gingerbenw commented 1 month ago

@yousif-bugsnag just that we've covered it with unit tests - but it wouldn't hurt to add one I suppose!