search

bugsnag / bugsnag-react-native

Error monitoring and reporting tool for native exceptions and JS errors in React Native apps
https://docs.bugsnag.com/platforms/react-native
MIT License
369 stars 121 forks source link

Missing TS definition for `codeBundleId` in Bugsnag.start() #479

Closed teodorciuraru closed 4 years ago

teodorciuraru commented 4 years ago

Steps to reproduce:

  1. npm install @bugsnag/react-native
  2. Type Bugsnag.start({codeBundleId: "my_id"})

You'll get: Object literal may only specify known properties, and 'codeBundleId' does not exist in type 'Pick<Config, Configurable>'.ts(2345)

Not really a big issue, but I wonder if codeBundleId still works in this new version. Will test that later.

abigailbramble commented 4 years ago

Hi @teo029 - thanks for the report! We will look into fixing this.

bengourley commented 4 years ago

Not really a big issue, but I wonder if codeBundleId still works in this new version. Will test that later.

It does work, it's just missing from the type definitions. Please convince your compiler of this until we ship the fix!

teodorciuraru commented 4 years ago

Not really a big issue, but I wonder if codeBundleId still works in this new version. Will test that later.

It does work, it's just missing from the type definitions. Please convince your compiler of this until we ship the fix!

Thanks, just wanted to make sure you know about it!

abigailbramble commented 4 years ago

We have now released a fix for this in v7.3.3.