search

bugst / go-serial

A cross-platform serial library for go-lang.
BSD 3-Clause "New" or "Revised" License
617 stars 188 forks source link

Use serial comm functions from golang.org/x/sys/windows #182

Closed twpayne closed 1 month ago

twpayne commented 3 months ago

I've opened a CL for golang.org/x/sys to add Windows serial communication functions: https://go-review.googlesource.com/c/sys/+/572295.

If/when this is merged and released, bugst/go-serial can drop its own implementation of these and use golang.org/x/sys/windows.

This PR is currently in draft as the functions are not yet merged or released in golang.org/x/sys/windows. If they make it in then I'll mark this PR as ready.

twpayne commented 2 months ago

golang.org/x/sys v0.19.0 has been released including the serial comm functions, so this is now ready for review.

twpayne commented 1 month ago

Closing due to inactivity.

cmaglie commented 1 week ago

@twpayne I'm sorry for the long delay in replying to PR, unfortunately, I run this project in my free time, so PR may take very long to process.

I see the value in the proposed changes, so I'd like to ask if you can reopen the PR, or if I can cheery pick your commits for future changes.