bugthesystem / FireSharp

An asynchronous cross-platform .Net library for Firebase
The Unlicense
696 stars 147 forks source link

QueryBuilder: Added support to long type for StartAt and EndAt #69

Closed iurmsepol closed 8 years ago

iurmsepol commented 8 years ago

Use case: using timestamp (long) type in firebase for filtering data.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.4%) to 41.542% when pulling 36b90d021473137024497c2888954156d1f8cfc5 on iurmsepol:master into 966c0bf95030525e46b5f5d16b75a9b99dc613d8 on ziyasal:master.

bugthesystem commented 8 years ago

Hi @iurmsepol thank you for your contribution, before merging your pull request could you please add tests?

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.5%) to 42.398% when pulling 2eac36eac6ed3f3864c4b5ada93156def28ea918 on iurmsepol:master into 966c0bf95030525e46b5f5d16b75a9b99dc613d8 on ziyasal:master.

iurmsepol commented 8 years ago

Done!