search

buidl-bitcoin / buidl-python

python3 bitcoin library with no dependencies and extensive test coverage
https://pypi.org/project/buidl/
MIT License
83 stars 26 forks source link

Add uncreative test for non-BIP67 inputs in create_multisig_psbt #122

Closed dhruvbansal closed 2 years ago

dhruvbansal commented 2 years ago

I've added a test for non-BIP67 compliant inputs passed to create_multisig_psbt.

The test merely passes the same info as an existing test, but explicitly uses the path_list construction instead. It's not very good because the input is still technically BIP67 compliant; we're just not sorting ourselves, rather getting it from the order of the pubkeys in the test.

mflaxman commented 2 years ago

This is perfect, thanks @dhruvbansal !