search

buildinspace / peru

a generic package manager, for including other people's code in your projects
MIT License
1.11k stars 69 forks source link

Adds a User-agent header to curl module requests #219

Closed colindean closed 2 years ago

colindean commented 2 years ago

The header will be of the form:

peru/{version} Python-urllib/{version}

Fixes #218

oconnor663 commented 2 years ago

It looks like the test failures here are something that changed in Git 2.34. I can repro them on my local machine, but they go away with I downgrade to Git 2.33. Will debug more tomorrow.

oconnor663 commented 2 years ago

I ended up bisecting Git itself to figure out what they heck they changed. Turns out it's this: https://github.com/git/git/commit/491a7575f188cbf6cfb5be75981a40beb4c22b44. A relatively obscure detail of how git read-tree respects .gitignore files has changed. There's a good chance I can find some flag(s) that restore the previous behavior, not quite sure yet.

oconnor663 commented 2 years ago

I'll move discussion of the test failure into a new issue: https://github.com/buildinspace/peru/issues/221