search

buildkite-plugins / docker-buildkite-plugin

🐳📦 Run any build step in a Docker container
MIT License
112 stars 106 forks source link

Add storage opts #181

Closed bennetty closed 2 years ago

bennetty commented 3 years ago

add storage opts flag

nithyaasworld commented 2 years ago

Thanks @bennetty for the PR! Sorry that it took us a long time to get to this. We verified it and we would be merging this soon.

Could you also please update the Readme file with an example for this and a little description? Thanks again!

nithyaasworld commented 2 years ago

@bennetty While the plugin works, the storage-opt flag is added as an array though it supposed to have only one value. I know it's long time since you initially worked on this PR! But if you would like, please update the changes that would accept storage-opt flag as a string rather than an array. Thanks for your contribution!

pzeballos commented 2 years ago

Thanks @bennetty for your contributions and sorry for the delay!!