search

buildkite-plugins / docker-buildkite-plugin

🐳📦 Run any build step in a Docker container
MIT License
112 stars 106 forks source link

Support for other docker commands than docker run #253

Closed linus345 closed 1 year ago

linus345 commented 1 year ago

Hey, are there any plans to support other docker commands then running a command in a container? For example introducing support for docker load. This would be useful in cases where you want to load a docker image before running a command in a container.

If there's no plans to add this, would you accept a PR introducing it if I opened one up?

toote commented 1 year ago

That is quite an interesting idea and we would be more than happy to review a PR if you create one.

Note, though that running a docker load on its own without an actual command for the plugin to take care might not make sense. It is possible that the clarification is not necessary, but I believe it is necessary because command is a term that has many meanings in this context (docker cli subcommand, command hook and actual step's command). I think that if you create a PR explaining the use case and proper tests we can continue the discussion there as well :)

linus345 commented 1 year ago

Created a PR for this #254, would appreciate any feedback you have