fix: schema inconsistencies

buildkite / pipeline-schema

A JSON schema for Buildkite’s pipeline file format

MIT License

31 stars 35 forks source link

fix: schema inconsistencies #65

Closed scadu closed 1 year ago

scadu commented 1 year ago

Addressed issues:

require steps attribute
allow group to be string and null as per documentation
add allow_dependency_failure and notify attributes to group

Resolves #44

timriley commented 1 year ago

Thanks for this, @scadu! I'll check this out in detail this week.

timriley commented 1 year ago

Hi @scadu! Thank you again for your contributions here, they're much appreciated!

I've just had the chance to take a closer look at everything, and I've just pushed a few amendments to make sure your changes are all exercised by tests.

Adding the tests revealed one amendment to the schema changes I had to make: I had to shift the spot where we allow group to be string or null to a slightly different spot (see ac024aa for details).

After all of this, I'm very happy to merge these changes now. Thanks for making it happen!