buildpacks / roadmap

Issue tracker
https://buildpacks.io
Apache License 2.0
0 stars 0 forks source link

The default run images MUST be encoded in the builder and not in the pack CLI config #31

Closed sclevine closed 5 years ago

sclevine commented 5 years ago

New config.toml:

default-stack-id = "io.buildpacks.stacks.bionic"

[[stacks]]
  id = "io.buildpacks.stacks.bionic"
  build-image = "packs/build"
  run-images = ["packs/run", "gcr.io/packs/run"]

[[builders]]
  image = "packs/sample"
  run-images = ["example.com/packs1/run", "example.com/packs2/run", "gcr.io/packs2/run",]

Need new command:

pack configure-builder <builder> -r example.com/packs1/run -r example.com/packs2/run

NOTE: this replaces the run image list every time

For pack inspect-remote-builder:

...
Run images:
  example.com/packs1/run (local)
  example.com/packs2/run (local)
  gcr.io/packs2/run (local)
  packs/run
  gcr.io/packs/run

Notes

Acceptance Criteria Given The above config.toml file without the builders section When I run pack build gcr.io/user/myapp --builder packs/sample Then gcr.io/packs/run is used to export the final image

Given The above config.toml file with the builders section When I run pack build gcr.io/user/myapp --builder packs/sample Then gcr.io/packs2/run is used to export the final image

Given The above config.toml file with the builders section When I run pack build example.com/user/myapp --builder packs/sample Then example.com/packs1/run is used to export the final image

ameyer-pivotal commented 5 years ago

A couple of questions:

sclevine commented 5 years ago

Updated OP.

jchesterpivotal commented 5 years ago

How we think we will work through this: